Repository navigation
fix(lock): honor SOURCE_DATE_EPOCH in lock timestamps - #33
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lock's timestamp now follows
SOURCE_DATE_EPOCHwhen that variable is a number of seconds.SOURCE_DATE_EPOCHwhen it is a decimal number of seconds since the Unix epoch, in UTC. An empty or non-numeric value still uses the current time.source_date_epoch_is_the_lock_timestampchecks that1700000000is written as2023-11-14T22:13:20Zon two solves, and that a non-numeric value is not that stamp. The commit has a towncrier fragment.